feat(#854): Add getServerSession and getToken to the local provider
#855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoey-kaiser
added
enhancement
zoey-kaiser
changed the title
getServerSession and getToken to the local-providergetServerSession and getToken to the local and refresh-provider
zoey-kaiser
changed the title
getServerSession and getToken to the local and refresh-providergetServerSession and getToken to the local provider
commit: |
phoenix-ru
reviewed
Sep 5, 2024
| const providerSpecificTypes: string[] = [] | ||
|
|
||
| if (provider.type === 'authjs') { | ||
| providerSpecificTypes.push(` const { getServerSession, getToken, NuxtAuthHandler }: typeof import('${resolve('./runtime/server/services/authjs')}')`) |
There was a problem hiding this comment.
Question - does this resolve relative to current path or from root? From the docs, it looks like the resolution will happen from the current path which is not correct:
https://nuxt.com/docs/api/advanced/import-meta#builder-properties
Comment on lines
+11
to
+14
| if (!token) { | ||
| return null | ||
| } | ||
| return token |
There was a problem hiding this comment.
formatToken already returns string | null
Suggested change
| if (!token) { | |
| return null | |
| } | |
| return token | |
| return token |
| import { formatToken } from '../../../utils/local' | ||
| import { useRuntimeConfig } from '#imports' | ||
|
|
||
| export function getToken(event: H3Event) { |
There was a problem hiding this comment.
Suggested change
| export function getToken(event: H3Event) { | |
| export function getToken(event: H3Event): string | null { |
| import type { SessionData } from '#auth' | ||
| import { useRuntimeConfig } from '#imports' | ||
|
|
||
| function joinPathToApiURL(event: H3Event, path: string) { |
There was a problem hiding this comment.
nit: would prefer if this was down the file as it is a helper (consumers are more interested in reading getServerSession
| baseURL = fullBaseUrl | ||
| } | ||
| else { | ||
| // Case 2: An origin was not supplied, we determine it from the request |
There was a problem hiding this comment.
This probably needs to happen only when trustHost is set (look at authjs implementation)
|
Closing. Will revisit when #913 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #854
❓ Type of change
📚 Description
Adds
getServerSessionandgetTokento the server-side ultis for thelocalprovider.📝 Checklist